Do I need to Turn on ICloud Photo Library for my pictures to be backed up

I'm a little confused I have an iPhone 8 Plus but soon I'm getting the XR I know when I switch the phone I need to backup everything which it automatically does, but I see that the ICloud Photo Library is off it saids that is to store all my pictures on to iCloud Library

Does that mean my photos aren't being backed up?! I'm confused in what it is and if I should turn that on or not

It's technically separate from the backups, but that doesn't mean your pictures are getting backed up. Apple purposely makes their backup system somewhat limited because they want people to subscribe to their iCloud Service.

Assuming you have iCloud backups turned on Apple gives you a measly 5gb of backups for free. You can pay for more. Generally 5gb is more than enough to backup things like your contacts and App data, but it's not going to be enough to back up most people's photos\videos. Unfortunately a fatal flaw in iPhones is that once your pictures gets too big for the backup it stops backing up anything. In this case it's actually better to turn off the standard photo backup so everything else can continue to backup properly. Other Apple suckers will just pay for the extra storage. Now most people at this point say wtf did you say? I need my photos backed up! That's where cloud photo library storage comes into play. It's a separate copy (aka backup) of photos stored in a cloud library, but it's different in that you can access all your pictures in this cloud library from multiple devices like iPad's, Mac, and PC's (via the web). This is helpful especially if you like taking pictures with a regular camera or other devices like an iPad since you can load all your pictures in one place and quickly access them from any device. The iCloud photo library is Apple's photo cloud, but will quickly cost you a subscription fee to have any meaningful amount of photos on it. So what do you do? You install the Google Photos App on your iPhone and it copies (backs up) all your photos and videos to Google's cloud for free in standard quality and you can still access it from your iPhone, iPad, Mac and PC.

Don't have to use iCloud for photos. Could try using Google Photos.

The simplest, doubt-free way to back up is with iTunes on your computer and a USB cable.

I trust iCloud myself and use it to sync photos with the computer (iCloud for Windows exists) and iPad. Go online, check that your stuff is up there, and make adjustments if necessary.