I just traded in my iPhone 4 for the iPhone 4s. Where's my contacts and photos? - 1

The iPhone 4 wasn't working too well so I just got a newer phone. The iPhone 5 was too expensive.
Anyway, where's my contacts and photos? The assistant put the old sim card into the new iphone. I also had a few songs on there. Shouldn't have everything just transferred over?
I may have this backed up on my Macbook.

Things won't transfer over automatically. Do you still have your iPhone 4? If so, you can create a backup in iTunes and then restore from that backup to your new 4s. If it wasn't working very well, you might want to be careful doing this. Certain apps can mess with phone performance and become corrupted, and there may be corrupted data on there that will carry over with the backup.

If you have the iPhone 4, plug it into iTunes and click on "iPhone" at the top right. In the second box, you will see a button that says "Back Up Now." Under this will show the date of your last backup. If you want, click back up now to create one.

To load from the back up (whether you just made one, or you want to use the one you think you already have on your Macbook), plug in your new phone. Click the 'iPhone" button at the top right, once it loads. Then in the second box, you will see a button that says "Restore Backup… " Click that. Select the backup you want to restore from. It may take some time, depending on how much stuff you had on your phone.

There you go! All your stuff will be there. If you did not have a backup and you do not have the phone, then you will have to re-download your purchases.

If you were able to successfully restore from a back up, keep a close eye on your phone's performance. If it starts acting like your old one, you will need to wipe it and set it up as a new device. You can manually or re-download your content, and this will keep you safe from whatever was causing the problem with your older phone.