Is iPhone 4s still good in 2014?

Will it get support for at least the next 2 years?

found a beast deal with it and its within my budget on a 2 year contract

will it maybe get ios 8?

Will its software still be supported and be able to run apps from now to 2016?

I have a 4s. I didn't get All of the updates from iOS 7. It may do the same as it did for the 4. The 4 didn't get the camera fitters or airplay. So we may get the new look but not the other stuff that comes with it. But otherwise it's good. Mine works fine. Really fine actually!

It should get the next iOS and be able to run current apps at least a year from then… So probably 1.5 years. A friend of mine didn't update from iOS 4 and was able to download apps for a year afterwards.

"will it get support for at least the next 2 years?"

Support as far as what? If you get it with a contract, your carrier will be contractually obligated to service it. It should run most of whatever apps are compatible with its version of iOS. Some iPhones don't run the newest stuff even though they support the newest iOS. Is that what you mean by support?

"will it maybe get ios 8?"

A very definite maybe.

There's no way to tell you what will happen. It's quite possible that iPhone 4 will also run iOS 8, which means that the 4s definitely will.

"Will its software still be supported and be able to run apps from now to 2016?"

I don't know what you mean by supported. Again, nobody can tell you what will happen. My iPod Touch 3rd Gen is supported in the sense that it can still run all of its apps and even get new ones as long as they don't require more than iOS 5.1.1.

"found a beast deal with it and its within my budget"

Whether a phone (or anything else for that matter) is a good deal depends on the price… Which your question left out entirely.